First of all, I'm using Windows 7. I know it's not ideal to be using an unsupported Operating System which is why I've included the osm for others to test. This is not a new bug though, I've had it before but never got around to testing properly and reporting it.
I think there's not just one problem, but a number of problems in various components causing clicks when retriggering notes, (e.g. in a mono synth). The attached file shows that when using a sine oscillator in combination with a stock ADSR, there are no evident clicks when the Midi module is in Mono mode, HOWEVER, there are a number of combinations which WILL cause clicks. I think the best way for me to demonstrate this is to give a list of instructions to follow:
1) Open the file and make sure the number of voices is set to 1 in the Midi to Poly module. You might like to experiment with combinations of hold/retrigger but I set them all on (except 'using samples').
2) Set the sound source to 'Sine' and the Envelope to 'Stock ADSR'. Play some notes. You might notice some tiny dull clicks but these are quite mild.
2b) Now set the envelope to either 'Stock MS Env' or 'New MS Env'. There's quite heavy clicking here.
3) Set the sound source to 'Wave Player' and select any envelope. Play some notes. There's some moderately heavy clicks here which are uniform across all of the envelopes which would suggest that something in the wave player is amiss...>>
3b) Now try Tzarl's Waveplayer for the sound source and notice how there's clicking with the stock Multi Stage envelopes but Tzarls workaround envelope and the stock ADSR/AHDSR produce a clean sound. This is of course the 'smooth retrig' option that Tzarls has given as a work-around. This envelope also solves the (2b) scenario.
So I guess there's two obvious problems here - firstly the stock Wave player, and secondly the stock multi-stage envelopes. I know Tzarls workarounds work well for both of these problems, but it's not a nice solution having to have those extra sections and code to solve the clicking. This is not something I've looked into in any depth because I'm only just starting to learn code so correct me if I'm wrong but shouldn't this be some behaviour within SM that needs to be fixed and not the modules themselves? Either way I think when offering 'stock' modules these need to be 100% clean so something needs to be addressed.
These are the clicks which stand out, but there seems to be some sort of click with just about any combination, some clicks are only just audible and some stand out like a sore thumb - either way there's definitely bugs somewhere. It would just be nice to be able to build even a simple synth with no glitching. I don't like to be bitchy either, but this is something which I can put together in less than a minute in Max/MSP. I've been mulling this one over for the last 6 hours or so, and browsing the forums, trying to get a solution. I guess all I'm asking for is a clean sound. I haven't built a click-free synth to date without having to compromise on stock components, and even when you think it's click free, one will jump up out of nowhere and ruin your piece!
P.S. Sorry if I'm repeating things that have already been covered but I've been away from SM for about a year now. If you need me to do any more testing give me a shout